Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN Native] Fix Video block crash on drawing on Android #15857

Merged
merged 2 commits into from May 29, 2019

Conversation

Projects
None yet
3 participants
@daniloercoli
Copy link
Contributor

commented May 28, 2019

This PR does fix a crash that happens on Android when the video file upload finishes and the block tries to render the preview. Details are here: wordpress-mobile/WordPress-Android#9943

Companion PR for GB-mobile: wordpress-mobile/gutenberg-mobile#1039

To test Android

  • Start the wp-android app
  • Add a video block to the editor and upload a video
  • Wait until the upload ends
  • The preview should be on the screen
  • No crash should happen
  • The bg color of the block is light grey

To test on iOS

  • Start the wp-iOS app
  • Add a video block to the editor and upload a video
  • Wait until the upload ends
  • The preview should be on the screen
  • No crash should happen
  • The bg color of the block is black
Merge branch 'master' of https://github.com/WordPress/gutenberg into …
…rnmobile/fix-video-block-crash-on-draw-android

* 'master' of https://github.com/WordPress/gutenberg:
  Disable video, quote blocks but for development (#15856)
@mkevins
Copy link
Contributor

left a comment

Tested this on Android (via WordPress-Android), and it does prevent the crash as described. LGTM! 🎉

@daniloercoli daniloercoli merged commit 95e73d9 into master May 29, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@daniloercoli daniloercoli deleted the rnmobile/fix-video-block-crash-on-draw-android branch May 29, 2019

@youknowriad youknowriad added this to the Gutenberg 5.9 milestone Jun 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.