Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inline docs and add tests for color utils #15861

Merged
merged 2 commits into from Jun 4, 2019

Conversation

@swissspidy
Copy link
Member

commented May 28, 2019

Description

I noticed that the stated return values for getColorObjectByAttributeValues, getColorObjectByColorValue, and getColorClassName were not entirely accurate.

This PR fixes that, and also adds some tests.

How has this been tested?

New tests added.

Types of changes

Bug fix (non-breaking change which fixes an issue). Documentation change only.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

swissspidy added some commits May 28, 2019

@swissspidy swissspidy changed the title Fix/colors utils docs tests Fix inline docs and add tests for color utils May 28, 2019

@gziolo gziolo requested a review from jorgefilipecosta May 28, 2019

@gziolo gziolo added this to the 5.9 (Gutenberg) milestone May 29, 2019

@swissspidy swissspidy merged commit fc08af8 into master Jun 4, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@swissspidy swissspidy deleted the fix/colors-utils-docs-tests branch Jun 4, 2019

nicolad added a commit to nicolad/gutenberg that referenced this pull request Jun 15, 2019

Fix inline docs and add tests for color utils (WordPress#15861)
* Correct inline docs for colors utils
* Adds some tests for the color utils

jg314 added a commit to jg314/gutenberg that referenced this pull request Jul 19, 2019

Fix inline docs and add tests for color utils (WordPress#15861)
* Correct inline docs for colors utils
* Adds some tests for the color utils
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.