Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint: Explicitly unignore ESLint config #15887

Merged
merged 1 commit into from May 29, 2019

Conversation

Projects
None yet
3 participants
@tfrommen
Copy link
Member

commented May 29, 2019

Description

ESLint, by default, does not lint the .eslintrc.js file.

This PR fixes that.

How has this been tested?

Run this:

./node_modules/.bin/eslint .eslintrc.js

Without the new entry in the .eslintignore file, ESLint will report that it is ignoring the config file.

With the new entry, all is good (or not, which would mean issues with the contents of the file 馃槈).

Types of changes

Unignore .eslintrc.js for ESLint.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@tfrommen tfrommen merged commit 13e5851 into master May 29, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@tfrommen tfrommen deleted the lint-eslint-config branch May 29, 2019

@youknowriad youknowriad added this to the Gutenberg 5.9 milestone Jun 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.