Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct default appender icon transition jump in Safari #15892

Merged
merged 1 commit into from May 30, 2019

Conversation

@kjellr
Copy link
Contributor

commented May 29, 2019

As noted in #15868, when hovering over the default appender icon to the left of the text field, Safari renders a tiny position jump:

broken

This is likely because the browser tries to shift the animation from the CPU to the GPU, mid-animation. 馃槙 By providing will-change: opacity (the newer version of the traditional translateZ(0) hack to fix this), we can tell the browser to render the animation using the GPU right from the start, and avoid this issue:

fixed

The docs for will-change recommend removing this after the animation happens, but I haven't been able to sort out a way to get that working here.

@kjellr kjellr added the [Type] Bug label May 29, 2019

@kjellr kjellr requested a review from jasmussen May 29, 2019

@kjellr kjellr self-assigned this May 29, 2019

@jorgefilipecosta
Copy link
Member

left a comment

Worked well on my tests 馃憤

@kjellr

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

Thanks!

@kjellr kjellr merged commit 1a6660c into master May 30, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@kjellr kjellr deleted the fix/jumpy-inserter-icon-in-safari branch May 30, 2019

@youknowriad youknowriad added this to the Gutenberg 5.9 milestone Jun 7, 2019

nicolad added a commit to nicolad/gutenberg that referenced this pull request Jun 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.