Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Redesign Table Block Placeholder #15903
Updated table block to use Placeholder component and implement design from #15820.
How has this been tested?
Updated e2e tests to reflect changed button text.
Steps to test:
Types of changes
Enhancement (non-breaking change which adds functionality)
requested review from
May 30, 2019
Thanks, @tellthemachines! This looks great.
Here's a screenshot:
I don't mind the labels-on-top, but I do think the number fields are a little long considering the content that'll go inside them. I wonder if we can narrow them down a bit? Something like this, perhaps: