Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port KeyboardAvoidingView, KeyboardAwareFlatList and ReadableContentView to @wordpress/components #15913

Merged
merged 3 commits into from Jun 3, 2019

Conversation

@Tug
Copy link
Contributor

commented May 30, 2019

This PR is step 2 of our mobile refactor wordpress-mobile/gutenberg-mobile#958

Description

Its goal is to port some of our reusable components that live in gutenberg-mobile to gutenberg so we can reuse them in gutenberg and thus port our other components as well.

How has this been tested?

Gutenberg mobile PR wordpress-mobile/gutenberg-mobile#1048

Types of changes

This is a refactor PR

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
@@ -0,0 +1,8 @@
.container {

This comment has been minimized.

Copy link
@gziolo

gziolo May 30, 2019

Member

Filename should be updated to style.native.scss to ensure it never gets included for the web version.

This comment has been minimized.

Copy link
@Tug

Tug May 30, 2019

Author Contributor

Thanks, updated!

@Tug Tug force-pushed the rnmobile/add/wordpress-components branch from 5182c78 to be2709d May 30, 2019

@pinarol

pinarol approved these changes Jun 3, 2019

Copy link
Contributor

left a comment

LGTM! Tested with the steps in parent PR

@Tug Tug merged commit 2627415 into master Jun 3, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
@Tug

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

Thanks for the review @pinarol 🙇

@Tug Tug deleted the rnmobile/add/wordpress-components branch Jun 3, 2019

@koke koke referenced this pull request Jun 6, 2019

Open

Convert BlockManager into BlockList #958

9 of 10 tasks complete

@youknowriad youknowriad added this to the Gutenberg 5.9 milestone Jun 7, 2019

nicolad added a commit to nicolad/gutenberg that referenced this pull request Jun 15, 2019

Port KeyboardAvoidingView, KeyboardAwareFlatList and ReadableContentV…
…iew to @wordpress/components (WordPress#15913)

* Port KeyboardAvoidingView, KeyboardAwareFlatList and ReadableContentView to @wordpress/components

* Rename readable-content-view style.scss to native.scss

* Fix bad Flow to ESNext port

jg314 added a commit to jg314/gutenberg that referenced this pull request Jul 19, 2019

Port KeyboardAvoidingView, KeyboardAwareFlatList and ReadableContentV…
…iew to @wordpress/components (WordPress#15913)

* Port KeyboardAvoidingView, KeyboardAwareFlatList and ReadableContentView to @wordpress/components

* Rename readable-content-view style.scss to native.scss

* Fix bad Flow to ESNext port
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.