Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove background color text from heading; Fix end to end tests; #15917

Merged
merged 1 commit into from May 30, 2019

Conversation

@jorgefilipecosta
Copy link
Member

commented May 30, 2019

Description

Background colors were removed from the heading.
#15784 was created when background colors still existed, meanwhile that PR was merged and that made the end 2 end tests fail.
CI tests were passing in that PR because at the time it was created background colors were still part of the editor.

How has this been tested?

I verified end to end tests are passing.

@gziolo

gziolo approved these changes May 30, 2019

Copy link
Member

left a comment

Travis says: aye. Let's get this in 👍

@gziolo gziolo added this to the 5.9 (Gutenberg) milestone May 30, 2019

@jorgefilipecosta jorgefilipecosta merged commit e88b5cc into master May 30, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@jorgefilipecosta jorgefilipecosta deleted the remove/background-color-test-from-heading branch May 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.