Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Update download link for Docker Desktop #15950

Merged
merged 1 commit into from Jun 3, 2019

Conversation

Projects
None yet
4 participants
@aduth
Copy link
Member

commented May 31, 2019

Relevant Slack conversation (link requires registration): https://wordpress.slack.com/archives/C02QB2JS7/p1559322698064000

This pull request seeks to update the download link for Docker which is displayed in the environment setup script when Docker is not installed. The previous like is now "Not Found", likely due to recent renaming of the Docker Community product to Docker Desktop.

@nerrad

nerrad approved these changes May 31, 2019

Copy link
Contributor

left a comment

I think this is better than a 404 so we should get it in. However, it's unfortunate that the page on docker is still unclear. The "Docker Desktop" name/label is used for both enterprise and the community edition (which apparently now is only accessible via Docker Hub (requiring signup)).

@aduth

This comment has been minimized.

Copy link
Member Author

commented May 31, 2019

@nerrad Hmm, furthermore, when already logged in to Docker Hub, the Download button just takes me to my dashboard. I wonder if it might be better to direct here:

https://hub.docker.com/search/?type=edition&offering=community

Which still prompts for login when selecting an option, but at least becomes a usable download link for everyone.

@aduth

This comment has been minimized.

Copy link
Member Author

commented Jun 3, 2019

Let's fix the 404, and consider it again if the proposed link ends up being problematic. Ideally we could lean on Docker to keep the product page a good canonical resource for downloading the application.

@aduth aduth merged commit d982302 into master Jun 3, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@aduth aduth deleted the update/docker-download-link branch Jun 3, 2019

@youknowriad youknowriad added this to the Gutenberg 5.9 milestone Jun 7, 2019

nicolad added a commit to nicolad/gutenberg that referenced this pull request Jun 15, 2019

jg314 added a commit to jg314/gutenberg that referenced this pull request Jul 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.