Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style quotes in the mobile app #15990

Merged
merged 4 commits into from Jun 5, 2019

Conversation

Projects
None yet
2 participants
@SergioEstevao
Copy link
Contributor

commented Jun 4, 2019

Description

This PR changes the BlockQuotation component to style the children element that has the citation identifier.

This allows us to set the space between the quote and citation and also to set a smaller font size.

How has this been tested?

This can be tested on GB mobile using this PR: wordpress-mobile/gutenberg-mobile#1067

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@SergioEstevao SergioEstevao added this to the 5.9 (Gutenberg) milestone Jun 4, 2019

@SergioEstevao SergioEstevao requested a review from koke Jun 4, 2019

@SergioEstevao SergioEstevao changed the title tyle quotes Style quotes in the mobile app Jun 4, 2019

@SergioEstevao SergioEstevao referenced this pull request Jun 4, 2019

Merged

Issue/207 quotes design review #1067

0 of 1 task complete
/**
* Internal dependencies
*/
import styles from './style.scss';

export const BlockQuotation = ( props ) => {
const newChildren = Children.map( props.children, ( child ) => {
if ( child && child.props.identifier === 'citation' ) {

This comment has been minimized.

Copy link
@koke

koke Jun 5, 2019

Contributor

I'm curious about why you need to test for child, is there any chance of that being null/undefined?

@SergioEstevao

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

@koke

koke approved these changes Jun 5, 2019

@SergioEstevao SergioEstevao merged commit 0f2b948 into master Jun 5, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@SergioEstevao SergioEstevao deleted the rnmobile/style_quotes branch Jun 5, 2019

nicolad added a commit to nicolad/gutenberg that referenced this pull request Jun 15, 2019

Style quotes in the mobile app (WordPress#15990)
* Add spacer between BlockQuotation elements.

* Use citation identifier to style rich-text

* Remove margin on quote bar.

jg314 added a commit to jg314/gutenberg that referenced this pull request Jul 19, 2019

Style quotes in the mobile app (WordPress#15990)
* Add spacer between BlockQuotation elements.

* Use citation identifier to style rich-text

* Remove margin on quote bar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.