Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video block has black background when upload is in progress or upload has failed #15991

Conversation

Projects
None yet
4 participants
@marecar3
Copy link
Contributor

commented Jun 4, 2019

Fixes : wordpress-mobile/gutenberg-mobile#1066

It's regression caused by #15857

To test :

Build WPiOS and WPAndroid against gutenberg-mobile PR : wordpress-mobile/gutenberg-mobile#1068

@marecar3

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

Hey @daniloercoli @pinarol, when I build WPAndroid against reverted changes from : #15857, I can't reproduce this issue : wordpress-mobile/WordPress-Android#9943

Is it maybe some Android platform version specific problem? I tried on 8.1 and 9.0 and it worked very well?

@daniloercoli

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

Is it maybe some Android platform version specific problem? I tried on 8.1 and 9.0 and it worked very well?

No @marecar3 - The issue was there on all versions of Android we tested. Android 9 and Android 7.1 were the ones I personally tested on real devices.

@pinarol

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

@marecar3 @daniloercoli I have updated the fix to add a wrapper View around Video just to be able to give the same background color for both platforms. If you can give it a try that'd be great.

Merge branch 'master' into rnmobile/1066-Video-block-has-black-backgr…
…ound-when-upload-is-in-progress-or-upload-has-failed
@marecar3

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

Test on both iOS and Android and it's working! Thanks @pinarol for jumping in! :)

@daniloercoli
Copy link
Contributor

left a comment

LGTM!

@marecar3 marecar3 merged commit 4c2eb54 into master Jun 5, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@marecar3 marecar3 deleted the rnmobile/1066-Video-block-has-black-background-when-upload-is-in-progress-or-upload-has-failed branch Jun 5, 2019

@youknowriad youknowriad added this to the Gutenberg 5.9 milestone Jun 7, 2019

nicolad added a commit to nicolad/gutenberg that referenced this pull request Jun 15, 2019

Video block has black background when upload is in progress or upload…
… has failed (WordPress#15991)

* Fixed issue with a black background when the upload is in progress or upload has failed

jg314 added a commit to jg314/gutenberg that referenced this pull request Jul 19, 2019

Video block has black background when upload is in progress or upload…
… has failed (WordPress#15991)

* Fixed issue with a black background when the upload is in progress or upload has failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.