Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile]Enable sound on video block #15997

Merged
merged 3 commits into from Jun 6, 2019

Conversation

Projects
None yet
3 participants
@pinarol
Copy link
Contributor

commented Jun 5, 2019

Description

Fix: wordpress-mobile/gutenberg-mobile#1072

How has this been tested?

Tested with steps on gutenberg mobile PR

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@pinarol pinarol requested review from koke and marecar3 Jun 5, 2019

@pinarol

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

hey @marecar3 👋 do you remember why setting mute=true was needed at first place?

@pinarol pinarol referenced this pull request Jun 5, 2019

Merged

Enable sound on video block #1073

1 of 1 task complete

@pinarol pinarol self-assigned this Jun 5, 2019

@marecar3

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

Hey @pinarol, as far as I remember when I started to work on video block, that line was already there, and I didn't ask/investigate why we set it initially to false.

@marecar3
Copy link
Contributor

left a comment

Nice job @pinarol, everything is perfect!

Merge branch 'master' into rnmobile/1072-video-has-no-sound
# Conflicts:
#	packages/block-library/src/video/edit.native.js

@pinarol pinarol merged commit 741921a into master Jun 6, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@pinarol pinarol deleted the rnmobile/1072-video-has-no-sound branch Jun 6, 2019

@youknowriad youknowriad added this to the Gutenberg 5.9 milestone Jun 7, 2019

nicolad added a commit to nicolad/gutenberg that referenced this pull request Jun 15, 2019

[Mobile]Enable sound on video block (WordPress#15997)
* Enable sound on video block

* Play sound even if device silent switch is set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.