Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile]Start playback immediately after video goes full screen #15998

Merged
merged 3 commits into from Jun 6, 2019

Conversation

Projects
None yet
3 participants
@pinarol
Copy link
Contributor

commented Jun 5, 2019

Fixes: wordpress-mobile/gutenberg-mobile#1074

How has this been tested?

tested with gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1075

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
Start playback immediately after we go full screen
Otherwise we need user to tap play again

@pinarol pinarol referenced this pull request Jun 5, 2019

Merged

Start playback immediately after video goes full screen #1075

1 of 1 task complete

@pinarol pinarol requested a review from koke Jun 5, 2019

@pinarol pinarol self-assigned this Jun 5, 2019

@marecar3 marecar3 self-requested a review Jun 5, 2019

@marecar3
Copy link
Contributor

left a comment

LGTM! :)

pinarol added some commits Jun 5, 2019

Merge branch 'master' into rnmobile/1074-user-needs-to-tap-play-twice
# Conflicts:
#	packages/block-library/src/video/video-player.ios.js

@pinarol pinarol merged commit d14166e into master Jun 6, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@pinarol pinarol deleted the rnmobile/1074-user-needs-to-tap-play-twice branch Jun 6, 2019

@youknowriad youknowriad added this to the Gutenberg 5.9 milestone Jun 7, 2019

nicolad added a commit to nicolad/gutenberg that referenced this pull request Jun 15, 2019

jg314 added a commit to jg314/gutenberg that referenced this pull request Jul 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.