Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mobile quotes insertion and removal of empty lines #16013

Merged

Conversation

Projects
None yet
3 participants
@SergioEstevao
Copy link
Contributor

commented Jun 5, 2019

Description

This PR changes the following:

  • Make sure that indices provided for selection by the native implementation are not out of the range of the format text.
  • Match the code to check for split on enter to the web equivalent.

How has this been tested?

This changes can be tested on this on GB-mobile using this PR:wordpress-mobile/gutenberg-mobile#1082

Screenshots

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
@koke

koke approved these changes Jun 6, 2019

@SergioEstevao SergioEstevao merged commit 6b2e834 into master Jun 6, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@SergioEstevao SergioEstevao deleted the rnmobile/fix_quotes_insert_remove_of_emptylines branch Jun 6, 2019

@youknowriad youknowriad added this to the Gutenberg 5.9 milestone Jun 7, 2019

nicolad added a commit to nicolad/gutenberg that referenced this pull request Jun 15, 2019

Fix mobile quotes insertion and removal of empty lines (WordPress#16013)
* Make sure selection is not over length of text.

* Replicate web behaviour for onSplit detection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.