Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Fix crash when deleting all content of RichText based block #16018

Merged
merged 1 commit into from Jun 6, 2019

Conversation

Projects
None yet
3 participants
@etoledom
Copy link
Contributor

commented Jun 6, 2019

forceSelectionUpdate definition was removed, but there was still this one line calling it.

To test:

  • Test remove all content from: (test on both Android and iOS)
    • Heading block
    • Paragraph block
    • List block
    • Quote block
Remove a call to a removed function.
This function is not needed anymore since selection is handed in the store
@SergioEstevao
Copy link
Contributor

left a comment

Tested on both iOS and Android and its working great. :shipit:

@etoledom etoledom merged commit 77f7b38 into master Jun 6, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
@etoledom

This comment has been minimized.

Copy link
Contributor Author

commented Jun 6, 2019

Thank you!

@etoledom etoledom deleted the rnmobile/force-selection-update-crash branch Jun 6, 2019

@youknowriad youknowriad added this to the Gutenberg 5.9 milestone Jun 7, 2019

nicolad added a commit to nicolad/gutenberg that referenced this pull request Jun 15, 2019

Remove a call to a removed function. (WordPress#16018)
This function is not needed anymore since selection is handed in the store

jg314 added a commit to jg314/gutenberg that referenced this pull request Jul 19, 2019

Remove a call to a removed function. (WordPress#16018)
This function is not needed anymore since selection is handed in the store
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.