Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update increase tooltip selector specificity #16043

Conversation

@jorgefilipecosta
Copy link
Member

jorgefilipecosta commented Jun 7, 2019

Description

Fix: #6681
The popover uses a min widget of 270px the tooltip needs to overwrite that style the rule to overwrite the popover style in the tooltip had the same specificity has the one on the popover. This only works because the code order is favorable and we had problems related to that in the past.
This PR just increases the tooltip rule specificity so we are not dependent on code order.
More details can be checked on the issue.

How has this been tested?

I verified the tooltips and popovers still work as expected.

@aduth
aduth approved these changes Jun 7, 2019
@jorgefilipecosta jorgefilipecosta merged commit 92fcaa8 into master Jun 7, 2019
10 checks passed
10 checks passed
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Travis CI - Pull Request Build Passed
Details
@jorgefilipecosta jorgefilipecosta deleted the update/increase-tootip-min-width-selector-speicficity branch Jun 7, 2019
@aduth aduth added this to the Gutenberg 5.9 milestone Jun 7, 2019
nicolad added a commit to nicolad/gutenberg that referenced this pull request Jun 15, 2019
jg314 added a commit to jg314/gutenberg that referenced this pull request Jul 19, 2019
sbardian added a commit to sbardian/gutenberg that referenced this pull request Jul 29, 2019
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.