Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add table block column alignment #16111
Adds column alignment options to the table block. Closes #15823
Applying an alignment adds a class name and
How has this been tested?
Added unit and e2e tests.
Manual testing steps:
Types of changes
New feature (non-breaking change which adds functionality)
Great question, @mtias. Right now the block only allows selection of a single cell at a time. I would love to see selections happen across rows and columns. Once this works, we can look at alignment across these.
This is my take on it as well.
I've refactored this to use classes, so it's ready for a code review
ellatrix left a comment
I have some strong opinion about the user experience of this, sorry.
I think center alignment can be perfectly fine in some cases, and we should not dictate that. However, I think that single cell alignment is a bit excessive. I'd rather have a text alignment toolbar button that applies to the whole table at once (since columns is a bit more complicated).