Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix: Don't render drop zone bellow the default block appender #16119
Currently, if we drag a block or a file above the default block appender we see the visual feedback that it is possible to drag it below the appender, we should not have that visual feedback.
I think we had some logic to handle the appender case. We added a flag
This PR fixes the isAppender flag/class computation and fixes the CSS to make sure when isAppender class is present only the top drop feedback border is visible.
How has this been tested?
I tried to drag & drop blocks and files in the editor and verified things still work as expected.
draganescu left a comment
I have tested this and there results are:
To replicate you should:
Hi @draganescu, thank you for your review! It seems the problem you found was not directly related to this code and after a rebase with master it stopped happening. Could you confirm if things work as expected now in your tests? Thank you in advance!