New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlapping editor notifications over admin submenus. #1630

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@andreg

andreg commented Jul 1, 2017

As shown in the above screenshot, I think that having notifications to overlap admin submenus is bad user experience, since that would force the user to close the notification first, before being able to access the submenu content.

Bringing down the z-index value of the .components-notice-list and .components-popover to 9989 should fix this issue. On the other hand I don't know if the previous value of 100000 was there for a reason or just a randomly "high" number and this modification would break something else in the UI.

@@ -13,8 +13,8 @@ $z-layers: (
'.editor-post-visibility__dialog': 30,
'.editor-post-schedule__dialog': 30,
'.editor-block-mover': 30,
'.components-notice-list': 100000,
'.components-popover': 100000,

This comment has been minimized.

@youknowriad

youknowriad Jul 1, 2017

Contributor

I think popovers should show up over admin submenus.

@youknowriad

youknowriad Jul 1, 2017

Contributor

I think popovers should show up over admin submenus.

This comment has been minimized.

@nylen

nylen Jul 5, 2017

Member

I don't think so - the notice is part of the Gutenberg UI, not something that should block you from using other wp-admin functions.

The design of traditional WP notices is very different (inline with the page, rather than popovers) but they don't suffer from this issue.

@nylen

nylen Jul 5, 2017

Member

I don't think so - the notice is part of the Gutenberg UI, not something that should block you from using other wp-admin functions.

The design of traditional WP notices is very different (inline with the page, rather than popovers) but they don't suffer from this issue.

This comment has been minimized.

@youknowriad

youknowriad Jul 5, 2017

Contributor

I agree about the notices, I was talking about the popovers (They can be full width and have a grayed background to cover the rest of the page)

@youknowriad

youknowriad Jul 5, 2017

Contributor

I agree about the notices, I was talking about the popovers (They can be full width and have a grayed background to cover the rest of the page)

This comment has been minimized.

@nylen

nylen Jul 5, 2017

Member

I would call this a modal. The gray background should prohibit expanding the admin menus in this case.

@nylen

nylen Jul 5, 2017

Member

I would call this a modal. The gray background should prohibit expanding the admin menus in this case.

This comment has been minimized.

@youknowriad

youknowriad Jul 8, 2017

Contributor

What if you open the inserter (which is a popover on a small screen), Should the inserter show up above or under the admin bar? I think it should be above

@youknowriad

youknowriad Jul 8, 2017

Contributor

What if you open the inserter (which is a popover on a small screen), Should the inserter show up above or under the admin bar? I think it should be above

Show outdated Hide outdated editor/assets/stylesheets/_z-index.scss Outdated
@andreg

This comment has been minimized.

Show comment
Hide comment
@andreg

andreg Jul 8, 2017

Added a comment indicating what z-index is used by admin submenus (including their selectors).

andreg commented Jul 8, 2017

Added a comment indicating what z-index is used by admin submenus (including their selectors).

@nylen

This comment has been minimized.

Show comment
Hide comment
@nylen

nylen Jul 13, 2017

Member

Continuing this one at #1884.

Member

nylen commented Jul 13, 2017

Continuing this one at #1884.

@nylen nylen closed this Jul 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment