Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile]Fix video upload #16331

Merged
merged 11 commits into from Jul 9, 2019

Conversation

@pinarol
Copy link
Contributor

commented Jun 27, 2019

Description

Fixes wordpress-mobile/gutenberg-mobile#1173

gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1182

How has this been tested?

Tested with gutenberg-mobile PR

Screenshots

Types of changes

  • We are removing setting of attributtes.url for local urls

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

pinarol added some commits Jun 27, 2019

@pinarol pinarol changed the title [Mobile]Try fix video upload [Mobile]Fix video upload Jun 27, 2019

@@ -64,7 +64,7 @@ class VideoEdit extends React.Component {

componentDidMount() {
const { attributes } = this.props;
if ( attributes.id && attributes.url && ! isURL( attributes.src ) ) {

This comment has been minimized.

Copy link
@pinarol

pinarol Jun 27, 2019

Author Contributor

I remember like attributes.url was not becoming undefined when we close/open a post during the upload. but now it is, so it is now useless and preventing the block from calling mediaUploadSync. maybe sth changed in the infrastructure that is causing this but I think removing this altogether should be fine.

@pinarol pinarol requested a review from etoledom Jun 27, 2019

@pinarol pinarol self-assigned this Jun 27, 2019

@pinarol pinarol requested a review from marecar3 Jun 28, 2019

@marecar3
Copy link
Contributor

left a comment

LGTM! 👍

etoledom added a commit that referenced this pull request Jul 8, 2019

This is a test commit with the changes from #16331
Trying to triger Travis CI with the same changes and see if it still fails JS Unit Tests

@etoledom etoledom merged commit 7a03158 into master Jul 9, 2019

1 of 2 checks passed

Filter merged Filter merged
Details
Travis CI - Pull Request Build Passed
Details

@etoledom etoledom deleted the rnmobile/fix-video-upload branch Jul 9, 2019

jg314 added a commit to jg314/gutenberg that referenced this pull request Jul 19, 2019

[Mobile]Fix video upload (WordPress#16331)
* Remove attributes.url usage

* Do not update src with local url

* Remove unnecessary state item and fix icon color

* Fix unit-tests

* Temp fix for the crashing side effect

* Revert changes

* Revert "Temp fix for the crashing side effect"

This reverts commit 1acb437.

@youknowriad youknowriad added this to the Gutenberg 6.2 milestone Jul 26, 2019

sbardian added a commit to sbardian/gutenberg that referenced this pull request Jul 29, 2019

[Mobile]Fix video upload (WordPress#16331)
* Remove attributes.url usage

* Do not update src with local url

* Remove unnecessary state item and fix icon color

* Fix unit-tests

* Temp fix for the crashing side effect

* Revert changes

* Revert "Temp fix for the crashing side effect"

This reverts commit 1acb437.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.