Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow inner block template options to wrap #16371

Merged
merged 2 commits into from Jul 1, 2019

Conversation

@kjellr
Copy link
Contributor

commented Jul 1, 2019

As noted in #16255 (comment), it appears that the InnerBlocks template options buttons get cut off on mobile, or at high levels of zoom. This PR allows template options to wrap, which fixes the mobile/zoom issue, and also allows for more flexibility in the number of template options presented.

Before Screenshots

columns-responsive-before

Example with 10 items:

Screen Shot 2019-07-01 at 9 55 02 AM

After Screenshots

columns-responsive

Example with 10 items:

Screen Shot 2019-07-01 at 9 53 37 AM

Copy link
Member

left a comment

Works well in my tests 👍 The changes make sense!

@kjellr kjellr merged commit 496a02c into master Jul 1, 2019
1 of 12 checks passed
1 of 12 checks passed
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Travis CI - Pull Request Build Passed
Details
@kjellr kjellr deleted the update/inner-blocks-template-picker-responsive branch Jul 1, 2019
@kjellr kjellr added this to the Gutenberg 6.1 milestone Jul 1, 2019
Tug added a commit that referenced this pull request Jul 9, 2019
* Allow inner block template options to wrap on mobile.

* Remove nowrap rule.
jg314 added a commit to jg314/gutenberg that referenced this pull request Jul 19, 2019
* Allow inner block template options to wrap on mobile.

* Remove nowrap rule.
sbardian added a commit to sbardian/gutenberg that referenced this pull request Jul 29, 2019
* Allow inner block template options to wrap on mobile.

* Remove nowrap rule.
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
* Allow inner block template options to wrap on mobile.

* Remove nowrap rule.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.