Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Change Permalinks" button when permalink is not editable #16395

Conversation

@jorgefilipecosta
Copy link
Member

commented Jul 2, 2019

Description

Fix: #12498

When we are editing a page that is the homepage of a website, the Permalink UI shows a Change Permalinks button that links to the settings page allowing the user to change the site-wide permalink structure. Given that the user pressed a link on a specific page, the user may not be aware a site-wide change is being applied.
This PR follows @mapk suggestion and removes the button.

How has this been tested?

I created a new page published it.
I went to the customizer, I selected "Homepage Settings" section, I set the page created on the previous step as the Homepage.
I opened the page in the editor and I verified 'Change Permalinks' was not available in the permalink editor.

@mapk

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

Looks great! I don't see any "Change Permalinks" button anymore. Thanks, @jorgefilipecosta!

Screen Shot 2019-07-24 at 7 45 56 AM

@jorgefilipecosta jorgefilipecosta merged commit c3a39f4 into master Jul 25, 2019

1 of 6 checks passed

Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Travis CI - Pull Request Build Passed
Details

@jorgefilipecosta jorgefilipecosta deleted the fix/remove-change-permalink-button-when-permalink-is-not-editable branch Jul 25, 2019

@youknowriad youknowriad added this to the Gutenberg 6.2 milestone Jul 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.