Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN Mobile] Track unsupported blocks list #16434

Merged
merged 7 commits into from Jul 9, 2019

Conversation

@daniloercoli
Copy link
Contributor

commented Jul 5, 2019

This PR is a part of the work required to fix wordpress-mobile/gutenberg-mobile#1199 and it does send the list of unsupported blocks up to the Native bridge when a post is opened. Previously only a flag to indicate the presence of unsupported blocks was sent up to the bridge.

To test: See wordpress-mobile/gutenberg-mobile#1199

@marecar3
Copy link
Contributor

left a comment

Working as described!
LGTM! 👍

@etoledom

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

Please do not merge until the iOS side is ready, since this change will break the iOS demo app.
I'll make take care of the needed changes asap :)

@etoledom
Copy link
Contributor

left a comment


RNReactNativeGutenbergBridge.editorDidMount( hasUnsupportedBlocks );
const unsupportedBlocksName = blocks.filter( isUnsupportedBlock ).map( ( block ) => block.attributes.originalName );
RNReactNativeGutenbergBridge.editorDidMount( unsupportedBlocksName );

This comment has been minimized.

Copy link
@etoledom

etoledom Jul 8, 2019

Contributor

Very small detail:
For consistency we could change the name from unsupportedBlocksName to unsupportedBlockNames

This comment has been minimized.

Copy link
@daniloercoli

daniloercoli Jul 8, 2019

Author Contributor

Right. Renamed!

daniloercoli and others added some commits Jul 8, 2019

Merge branch 'master' of https://github.com/WordPress/gutenberg into …
…rnmobile/track-unsupported-blocks

* 'master' of https://github.com/WordPress/gutenberg:
  Bump plugin version to 6.1.0-rc.1
  Update HTML anchor explaination text (#16142)
  Move post permalink to beneath title on mobile. (#16277)
  Export cloneBlock method to the mobile (#16441)
  Fix inconsistent references to Settings Sidebar (#16138)
  Adds a cache key to the blocks reducer in order to optimize the getBlock selector (#16407)
  Track the parent block to optimize hierarchy selectors (#16392)

@etoledom etoledom merged commit 04af1c1 into master Jul 9, 2019

1 of 2 checks passed

Filter merged Filter merged
Details
Travis CI - Pull Request Build Passed
Details

@etoledom etoledom deleted the rnmobile/track-unsupported-blocks branch Jul 9, 2019

jg314 added a commit to jg314/gutenberg that referenced this pull request Jul 19, 2019

[RN Mobile] Track unsupported blocks list (WordPress#16434)
* Send the list of unsupported blocks up to the Native bridge

* Update test

* Update test again

* Rename variable

* Remove unused var

@youknowriad youknowriad added this to the Gutenberg 6.2 milestone Jul 26, 2019

sbardian added a commit to sbardian/gutenberg that referenced this pull request Jul 29, 2019

[RN Mobile] Track unsupported blocks list (WordPress#16434)
* Send the list of unsupported blocks up to the Native bridge

* Update test

* Update test again

* Rename variable

* Remove unused var
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.