Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest post block iteration: featured image add. #16448

Open
wants to merge 3 commits into
base: master
from

Conversation

@nicolad
Copy link
Member

nicolad commented Jul 7, 2019

Description

Fixes: #1594

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
@nicolad

This comment has been minimized.

Copy link
Member Author

nicolad commented Jul 7, 2019

Have reused some logic as suggested by @gziolo from @ajitbohra's closed WIP PR.

Copy link
Member

Soean left a comment

Thanks for the PR. You also have to add this feature to the PHP file, otherwise the image will not be rendered on the frontend.

@nicolad nicolad changed the title Latest post block iteration: featured image add. WIP: Latest post block iteration: featured image add. Jul 8, 2019
@nicolad

This comment has been minimized.

Copy link
Member Author

nicolad commented Jul 8, 2019

Thanks for the PR. You also have to add this feature to the PHP file, otherwise the image will not be rendered on the frontend.

Sure, this will be the next focus, now this PR is still a WIP.

@paaljoachim paaljoachim mentioned this pull request Aug 25, 2019
0 of 3 tasks complete
@paaljoachim

This comment has been minimized.

Copy link

paaljoachim commented Nov 2, 2019

Hi @nicolad

Can we get a status update on where this PR is at the moment?
Thanks.

@nicolad nicolad changed the title WIP: Latest post block iteration: featured image add. Latest post block iteration: featured image add. Nov 3, 2019
@nicolad nicolad requested a review from Soean Nov 3, 2019
@nicolad

This comment has been minimized.

Copy link
Member Author

nicolad commented Nov 3, 2019

Hi @nicolad

Can we get a status update on where this PR is at the moment?
Thanks.

Hey @paaljoachim
It's ready for review now.
Thanks for chiming in 👍

@nicolad nicolad requested a review from WordPress/gutenberg-core Nov 3, 2019
@youknowriad youknowriad requested review from mapk and melchoyce Nov 11, 2019
@melchoyce

This comment has been minimized.

Copy link
Contributor

melchoyce commented Nov 11, 2019

Hey, have y'all also seen #17151?

@paaljoachim

This comment has been minimized.

Copy link

paaljoachim commented Nov 12, 2019

I noticed that Riad checked out the other Latest Post Block: featured image feature. So I believe what is important here is just comparing both and figuring out where to take it from there.
@youknowriad

@mapk

This comment has been minimized.

Copy link
Contributor

mapk commented Nov 21, 2019

I was able to test this briefly, but after making a couple settings changes in the block's settings like number of posts... I am now continually getting this error.

Screen Shot 2019-11-20 at 5 36 46 PM

I delete the block and try readding it, but keep getting the same error. I've even tried on different posts, etc., but same error.

@mcsf mcsf added the [Status] Stale label Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.