Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dynamic blocks documentation #16450

Merged
merged 2 commits into from Jul 17, 2019

Conversation

@jodamo5
Copy link
Contributor

commented Jul 7, 2019

#16374 Description
Added in adjustments that @chrisvanpatten recommended on the last update, but they were accidentally removed before the final pull request. Also have added in a line mentioning that if using InnerBlocks these need to be saved using the save callback.

How has this been tested?

Most changes here are simply text changes to improve the understanding. The InnerBlocks explanation has been tested on both development and live sites.

Types of changes

Just further explanations in the documentation.

Update dynamic blocks documentation
Added in adjustments that @chrisvanpatten recommended on the last update, but they were accidentally removed before the final pull request.  Also have added in a line mentioning that if using InnerBlocks these need to be saved using the save callback.
@jodamo5

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2019

One of the tests failed, but seems like a mistake, as no code was actually changed on this file - just text changes. Can someone look into this please?

@Soean

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

@jodamo5 We had some issues with the tests yesterday. I restarted them and now they are fine :-)

@jodamo5

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

Thanks @Soean. Tests have passed. Can someone please merge this in? Thanks.

@mkaz
Copy link
Member

left a comment

I added a suggestion to show how to save the content. If there is a link to an example block that would be good to include but not necessary.

Update docs/designers-developers/developers/tutorials/block-tutorial/…
…creating-dynamic-blocks.md


Example added showing how to save InnerBlocks.

Co-Authored-By: Marcus Kazmierczak <marcus@mkaz.com>
@mkaz

mkaz approved these changes Jul 17, 2019

Copy link
Member

left a comment

Looks good, thanks for the updates!

@mkaz mkaz merged commit 07f19f1 into WordPress:master Jul 17, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@github-actions github-actions bot added this to the Gutenberg 6.1 milestone Jul 17, 2019

jffng added a commit to jffng/gutenberg that referenced this pull request Jul 18, 2019

Update dynamic blocks documentation (WordPress#16450)
* Update dynamic blocks documentation

Added in adjustments that @chrisvanpatten recommended on the last update, but they were accidentally removed before the final pull request.  Also have added in a line mentioning that if using InnerBlocks these need to be saved using the save callback.

* Update docs/designers-developers/developers/tutorials/block-tutorial/creating-dynamic-blocks.md

Example added showing how to save InnerBlocks.

Co-Authored-By: Marcus Kazmierczak <marcus@mkaz.com>

mcsf added a commit that referenced this pull request Jul 19, 2019

Update dynamic blocks documentation (#16450)
* Update dynamic blocks documentation

Added in adjustments that @chrisvanpatten recommended on the last update, but they were accidentally removed before the final pull request.  Also have added in a line mentioning that if using InnerBlocks these need to be saved using the save callback.

* Update docs/designers-developers/developers/tutorials/block-tutorial/creating-dynamic-blocks.md

Example added showing how to save InnerBlocks.

Co-Authored-By: Marcus Kazmierczak <marcus@mkaz.com>

jg314 added a commit to jg314/gutenberg that referenced this pull request Jul 19, 2019

Update dynamic blocks documentation (WordPress#16450)
* Update dynamic blocks documentation

Added in adjustments that @chrisvanpatten recommended on the last update, but they were accidentally removed before the final pull request.  Also have added in a line mentioning that if using InnerBlocks these need to be saved using the save callback.

* Update docs/designers-developers/developers/tutorials/block-tutorial/creating-dynamic-blocks.md

Example added showing how to save InnerBlocks.

Co-Authored-By: Marcus Kazmierczak <marcus@mkaz.com>

sbardian added a commit to sbardian/gutenberg that referenced this pull request Jul 29, 2019

Update dynamic blocks documentation (WordPress#16450)
* Update dynamic blocks documentation

Added in adjustments that @chrisvanpatten recommended on the last update, but they were accidentally removed before the final pull request.  Also have added in a line mentioning that if using InnerBlocks these need to be saved using the save callback.

* Update docs/designers-developers/developers/tutorials/block-tutorial/creating-dynamic-blocks.md

Example added showing how to save InnerBlocks.

Co-Authored-By: Marcus Kazmierczak <marcus@mkaz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.