Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Tooling: Wait for MySQL availability before install #16461

Merged
merged 1 commit into from Jul 8, 2019

Conversation

@aduth
Copy link
Member

commented Jul 8, 2019

This pull request seeks to resolve an issue where Travis builds may fail in the "PHP unit tests (Docker)" task. The issue is caused by a race condition which can occur when the MySQL container is not given sufficient time to initialize before the WordPress test procedure begins. This can cause errors to occur when the database is unavailable and refuses connections.

The changes here resolve this issue by waiting for the MySQL host to be available to receive connections before proceeding with the installation procedure.

Testing Instructions:

Verify the Travis build passes, and that the logs of the "PHP unit tests (Docker)" are sensible and include the expected PHP test cases result.

@aduth aduth force-pushed the fix/travis-php-build-failure branch from b69edac to 2feca44 Jul 8, 2019

@aduth aduth changed the title Build: Resolve Travis PHP build failures Build Tooling: Wait for MySQL availability before install Jul 8, 2019

@youknowriad
Copy link
Contributor

left a comment

Thanks

@ntwb

ntwb approved these changes Jul 8, 2019

@mkaz

mkaz approved these changes Jul 8, 2019

Copy link
Member

left a comment

Looks good, we had to do something similar to wait for mysql to come up.
It takes a little longer in docker

@mkaz mkaz merged commit 7f4c1c3 into master Jul 8, 2019

1 of 7 checks passed

Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Travis CI - Pull Request Build Passed
Details

@mkaz mkaz deleted the fix/travis-php-build-failure branch Jul 8, 2019

@github-actions github-actions bot added this to the Gutenberg 6.2 milestone Jul 8, 2019

jg314 added a commit to jg314/gutenberg that referenced this pull request Jul 19, 2019

sbardian added a commit to sbardian/gutenberg that referenced this pull request Jul 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.