Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ./node_modules/ from require in example #16470

Merged
merged 1 commit into from Jul 9, 2019

Conversation

@ajlende
Copy link
Contributor

commented Jul 8, 2019

Description

Noticed this when following the example for configuring webpack. Node will automatically resolve modules from the node_modules directory, so ./node_modules/ doesn't need to be listed in the require.

Types of changes

Documentation

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
Remove ./node_modules/ from require in example
Node will automatically look in the node_modules directory, so listing it isn't needed
@aduth

aduth approved these changes Jul 9, 2019

@aduth

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

Thanks for the improvement!

@aduth aduth merged commit bd23075 into WordPress:master Jul 9, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@github-actions github-actions bot added this to the Gutenberg 6.2 milestone Jul 9, 2019

jg314 added a commit to jg314/gutenberg that referenced this pull request Jul 19, 2019

Remove ./node_modules/ from require in example (WordPress#16470)
Node will automatically look in the node_modules directory, so listing it isn't needed

sbardian added a commit to sbardian/gutenberg that referenced this pull request Jul 29, 2019

Remove ./node_modules/ from require in example (WordPress#16470)
Node will automatically look in the node_modules directory, so listing it isn't needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.