Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the columns count control on empty columns block #16476

Merged
merged 2 commits into from Jul 15, 2019

Conversation

@youknowriad
Copy link
Contributor

commented Jul 9, 2019

Small regression introduced by #16129

closes #16343

When the columns block is in the "setup state", the columns count range control should be hidden.

@Soean

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

Fixes #16343

@aduth

aduth approved these changes Jul 12, 2019

@@ -170,9 +172,7 @@ export function ColumnsEdit( {
setForceUseTemplate( true );
} }
__experimentalAllowTemplateOptionSkip
// setting the template to null when the inner blocks

This comment has been minimized.

Copy link
@aduth

aduth Jul 12, 2019

Member

Seems like this comment is still valid?

return (
<>
{ template && (
{ ! showTemplateSelector && (

This comment has been minimized.

Copy link
@aduth

aduth Jul 12, 2019

Member

Alternatively, I wonder what it is about choosing columns that causes the issue in the first place. If someone wanted to skip the layout selection and just start setting columns (assuming of an equal width), why prevent them?

This comment has been minimized.

Copy link
@youknowriad

youknowriad Jul 12, 2019

Author Contributor

yeah I'm not sure what. I decided to remove the selector not only because of the bug because based on the previous check here. I assumed that removing the inspector controls was an intentional behavior.

@youknowriad youknowriad merged commit c3d80db into master Jul 15, 2019

1 of 2 checks passed

Filter merged Filter merged
Details
Travis CI - Pull Request Build Passed
Details

@youknowriad youknowriad deleted the fix/hide-columns-setup-state branch Jul 15, 2019

jg314 added a commit to jg314/gutenberg that referenced this pull request Jul 19, 2019

@youknowriad youknowriad added this to the Gutenberg 6.2 milestone Jul 26, 2019

sbardian added a commit to sbardian/gutenberg that referenced this pull request Jul 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.