Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Preview button on mobile viewports #16496

Merged
merged 1 commit into from Jul 10, 2019

Conversation

@noisysocks
Copy link
Member

commented Jul 10, 2019

Fixes #8184.

localhost_8888_wp-admin_post php_post=13 action=edit(iPhone 6_7_8)

Displays the Preview button and renames Switch to Draft to Draft on mobile viewports. This allows mobile users to easily preview their published posts.

To test:

  1. Create a new post
  2. Click Publish... and publish the post
  3. On a mobile viewport, confirm that you now see a Preview button
Show Preview button on mobile viewports
Displays the Preview button and renames 'Switch to Draft' to 'Draft' on
mobile viewports. This allows mobile users to easily preview their
published posts.
@jorgefilipecosta
Copy link
Member

left a comment

Works well on my tests, and the code changes look good 👍

@kjellr

kjellr approved these changes Jul 10, 2019

Copy link
Contributor

left a comment

Thanks, @noisysocks! I tested across a number of common mobile breakpoints, and this works well in all of them. 🚢

@karmatosed

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

This is great @noisysocks - let's ship!

@karmatosed karmatosed merged commit 1731607 into master Jul 10, 2019

1 of 9 checks passed

Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Travis CI - Pull Request Build Passed
Details

@github-actions github-actions bot added this to the Gutenberg 6.2 milestone Jul 10, 2019

@kjellr kjellr deleted the update/show-post-preview-button-on-mobile branch Jul 10, 2019

jg314 added a commit to jg314/gutenberg that referenced this pull request Jul 19, 2019

Show Preview button on mobile viewports (WordPress#16496)
Displays the Preview button and renames 'Switch to Draft' to 'Draft' on
mobile viewports. This allows mobile users to easily preview their
published posts.

sbardian added a commit to sbardian/gutenberg that referenced this pull request Jul 29, 2019

Show Preview button on mobile viewports (WordPress#16496)
Displays the Preview button and renames 'Switch to Draft' to 'Draft' on
mobile viewports. This allows mobile users to easily preview their
published posts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.