Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
WIP: Install a block from inserter #16524
Extend the inserter to show available blocks for download and silently install the block when the block is inserted into the editor
This PR is still a WIP. Can you help guide me with the implementation and avoiding any pitfalls? I'm new to the block editor.
Types of changes
[design] Mockup feedback
[dev] Block Directory Proposal
[dev] Block Registration
[dev] Block Registration - assets JSON structure
GitHub Block Directory issues
GitHub Block Directory project
gziolo left a comment
Great refactor, I left some nitpicks while doing a review of the general architecture. This is exactly what we discussed last time. I don't think I have any concerns on how it shapes. @youknowriad might need to confirm that but I guess we are in the position where we can focus on the implementation details. I'd love us to find a way to split this PR into a few incremental steps to make the process easier to share feedback.
talldan left a comment
Hey @ck-lee. I've had another look over the code. Looks good so far!
It is quite a sizeable PR so difficult to review it all thoroughly. I'm wondering if there might be a strategy for splitting this into smaller chunks and merging parts of this behind a feature flag (https://developer.wordpress.org/block-editor/developers/feature-flags/).
The slot could be a good first thing to attempt to merge in a much smaller PR.