Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSX Tag Name is not same | Snipped works now #16526

Merged
merged 3 commits into from Jul 11, 2019

Conversation

@BenjaminZekavica
Copy link
Contributor

commented Jul 11, 2019

Change correct Tag Name.

@Soean

Soean approved these changes Jul 11, 2019

Copy link
Member

left a comment

Thanks, good catch!

packages/edit-post/README.md Outdated Show resolved Hide resolved
Update packages/edit-post/README.md
Co-Authored-By: Sören Wrede <soerenwrede@gmail.com>
@Soean
Copy link
Member

left a comment

Oh, I was too fast. The tests are failing, because this file is generated from the source files. You need to change the source in the file /packages/edit-post/src/components/sidebar/plugin-document-setting-panel/index.js in line 73 and then run the command npm run docs:build to generate the Readme.md file.

@BenjaminZekavica

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

@Soean Now it's done :) Could you check it now?

@Soean

Soean approved these changes Jul 11, 2019

Copy link
Member

left a comment

Tests are green, now its working, thanks!

@Soean Soean merged commit 4bd0556 into WordPress:master Jul 11, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@github-actions github-actions bot added this to the Gutenberg 6.2 milestone Jul 11, 2019

Tug added a commit that referenced this pull request Jul 12, 2019

Docs: JSX Tag Name is not same | Snipped works now (#16526)
* JSX Tag Name is not same | Snipped works now

* Update packages/edit-post/README.md

Co-Authored-By: Sören Wrede <soerenwrede@gmail.com>

* Documentation Change -> Change Plugin Documentation Setting Panel Readme

jg314 added a commit to jg314/gutenberg that referenced this pull request Jul 19, 2019

Docs: JSX Tag Name is not same | Snipped works now (WordPress#16526)
* JSX Tag Name is not same | Snipped works now

* Update packages/edit-post/README.md

Co-Authored-By: Sören Wrede <soerenwrede@gmail.com>

* Documentation Change -> Change Plugin Documentation Setting Panel Readme

sbardian added a commit to sbardian/gutenberg that referenced this pull request Jul 29, 2019

Docs: JSX Tag Name is not same | Snipped works now (WordPress#16526)
* JSX Tag Name is not same | Snipped works now

* Update packages/edit-post/README.md

Co-Authored-By: Sören Wrede <soerenwrede@gmail.com>

* Documentation Change -> Change Plugin Documentation Setting Panel Readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.