Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add title attribute to PluginDocumentSettingPanel example #16528

Merged
merged 1 commit into from Jul 12, 2019

Conversation

@Soean
Copy link
Member

commented Jul 11, 2019

Description

Adds title attributes to the new PluginDocumentSettingPanel examples:
If we don't have a title the panel is not visible.

Before:
before

After:
after

@Soean Soean requested review from talldan and youknowriad as code owners Jul 11, 2019

@Soean Soean self-assigned this Jul 11, 2019

@jorgefilipecosta
Copy link
Member

left a comment

I verified that in the previous example the panel did not appear (by pasting the es5 version on the browser console) and with these changes, it works as expected 👍

@Soean Soean merged commit 86c1562 into master Jul 12, 2019

1 of 6 checks passed

Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Travis CI - Pull Request Build Passed
Details

@Soean Soean deleted the docs/add-title-to-PluginDocumentSettingPanel-axample branch Jul 12, 2019

Tug added a commit that referenced this pull request Jul 12, 2019

talldan added a commit that referenced this pull request Jul 15, 2019

jg314 added a commit to jg314/gutenberg that referenced this pull request Jul 19, 2019

@youknowriad youknowriad added this to the Gutenberg 6.2 milestone Jul 26, 2019

sbardian added a commit to sbardian/gutenberg that referenced this pull request Jul 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.