Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where the toolbar can be hidden for the block after a wide aligned image #16530

Merged
merged 1 commit into from Jul 11, 2019

Conversation

@youknowriad
Copy link
Contributor

commented Jul 11, 2019

closes #16519

Testing instructions

  • Insert a full aligned image
  • Insert a paragraph after the image
  • The paragraph's toolbar should not be cropped.

@youknowriad youknowriad requested a review from ellatrix Jul 11, 2019

@youknowriad youknowriad requested review from gziolo and talldan as code owners Jul 11, 2019

@youknowriad youknowriad self-assigned this Jul 11, 2019

@jorgefilipecosta
Copy link
Member

left a comment

I was able to replicate the problem in master and it is solved on this branch.

ref.current.style.transform = `translate3d(${ newTransform.x }px,${ newTransform.y }px,0)`;
ref.current.style.transform = newTransform.x === 0 && newTransform.y === 0 ?
undefined :
`translate3d(${ newTransform.x }px,${ newTransform.y }px,0)`;

This comment has been minimized.

Copy link
@jorgefilipecosta

jorgefilipecosta Jul 11, 2019

Member

I wonder why applying a translate3d with all coordinates as 0 causes this problem, it seems unexpected. Supposedly translate3d(0,0,0) is a common "hack" to force hardware acceleration and makes CSS transitions smoother, but I did not expect a visual impact.

This comment has been minimized.

Copy link
@youknowriad

youknowriad Jul 11, 2019

Author Contributor

Yes, I don't know it seems to mess up with z-index somehow.

@youknowriad youknowriad merged commit 6860857 into master Jul 11, 2019

1 of 7 checks passed

Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Travis CI - Pull Request Build Passed
Details

@youknowriad youknowriad deleted the fix/z-index-issue-animation branch Jul 11, 2019

Tug added a commit that referenced this pull request Jul 12, 2019

jg314 added a commit to jg314/gutenberg that referenced this pull request Jul 19, 2019

@youknowriad youknowriad added this to the Gutenberg 6.2 milestone Jul 26, 2019

sbardian added a commit to sbardian/gutenberg that referenced this pull request Jul 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.