Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Show "add block here" placeholder when adding block from title #16539

Merged
merged 1 commit into from Jul 19, 2019

Conversation

@mchowning
Copy link
Contributor

commented Jul 11, 2019

Description

Fixes issue where the "add block here" indicator was not shown if the new block was being added while the post's title is selected.

How has this been tested?

See related mobile-gutenberg PR

Types of changes

Non-breaking change to fix a bug.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
@marecar3
Copy link
Contributor

left a comment

Nice work @mchowning ! 🎉
I think that we are good to go with this one!

@mchowning mchowning merged commit 6ef0222 into master Jul 19, 2019

1 of 6 checks passed

Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Travis CI - Pull Request Build Passed
Details

@mchowning mchowning deleted the rnmobile/show_add_block_placeholder_from_title branch Jul 19, 2019

@youknowriad youknowriad added this to the Gutenberg 6.2 milestone Jul 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.