Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Tooling: Avoid Docker container automatic restart #16547

Merged
merged 1 commit into from Jul 12, 2019

Conversation

@aduth
Copy link
Member

commented Jul 11, 2019

Previously: #14638

This pull request seeks to remove restart: always configurations from all container configurations in docker-compose.yml. Specifically, the wordpress:cli and composer containers are not typically intended to be "kept up" and are instead mostly used for one-off commands. The restart directive will cause the containers to restart infinitely. While there may potentially be some benefit in keeping this configuration for other containers, I'm not convinced it's necessary, and it may be more worthwhile for unexpected halts to be surfaced more prominently than to be restarted automatically.

Testing Instructions:

  1. docker-compose stop && docker-compose up -d
  2. Verify that when executing docker container ls, you do not see any containers with a status "Restarting".

@aduth aduth requested a review from gziolo Jul 11, 2019

@mcsf

mcsf approved these changes Jul 12, 2019

Copy link
Contributor

left a comment

While there may potentially be some benefit in keeping this configuration for other containers, I'm not convinced it's necessary, and it may be more worthwhile for unexpected halts to be surfaced more prominently than to be restarted automatically.

I agree. Let's see if this reveals any other issues.

@aduth aduth merged commit d417aa5 into master Jul 12, 2019

1 of 4 checks passed

Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Travis CI - Pull Request Build Passed
Details

@aduth aduth deleted the remove/docker-restart branch Jul 12, 2019

jg314 added a commit to jg314/gutenberg that referenced this pull request Jul 19, 2019

@youknowriad youknowriad added this to the Gutenberg 6.2 milestone Jul 26, 2019

sbardian added a commit to sbardian/gutenberg that referenced this pull request Jul 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.