Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visible focus and active styles for Windows high contrast mode #16554

Merged
merged 2 commits into from Jul 30, 2019

Conversation

@tellthemachines
Copy link
Contributor

commented Jul 12, 2019

Description

Removed the negative outline-offsets that were making outlines hard to see;
Added focus outline for calendar buttons (the ones for navigating from month to month);
Added thin outline for color picker buttons to be visible;
Added thin dotted outlines for active states in toolbar. (Would appreciate design input on this - settled for dotted because a thin solid outline was hard to tell apart from the toolbar outline itself - see attached screenshots.)

How has this been tested?

Tested locally on Windows 10 set to high contrast mode, with Edge, IE and Firefox.
Used keyboard to tab through several blocks as well as the Block and Document sections of the sidebar.

Screenshots

color_settings_hc

Toolbar on Edge:

toolbar_Edge

Toolbar on Firefox:

toolbar_Firefox

Toolbar on IE:

toolbar_IE

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
@afercia

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

Thanks @tellthemachines ! Looks good from an accessibility perspective!

@tellthemachines tellthemachines force-pushed the fix/visible-states-high-contrast branch from 702de4a to 0e8c1f3 Jul 29, 2019

@draganescu
Copy link
Contributor

left a comment

Does what it says on the box.

@tellthemachines tellthemachines merged commit 9446f27 into master Jul 30, 2019

1 of 2 checks passed

Milestone It Milestone It
Details
Travis CI - Pull Request Build Passed
Details

@github-actions github-actions bot added this to the Gutenberg 6.3 milestone Jul 30, 2019

@mtias mtias deleted the fix/visible-states-high-contrast branch Aug 3, 2019

@klihelp

This comment has been minimized.

Copy link

commented Aug 14, 2019

+1

gziolo added a commit that referenced this pull request Aug 29, 2019
Visible focus and active styles for Windows high contrast mode (#16554)
* Visible focus/active styles in high contrast mode.

* Updated mixin call.
gziolo added a commit that referenced this pull request Aug 29, 2019
Visible focus and active styles for Windows high contrast mode (#16554)
* Visible focus/active styles in high contrast mode.

* Updated mixin call.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.