Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Replace use of deprecated componentWillReceiveProps in ImageEdit #16577

Conversation

@mchowning
Copy link
Contributor

commented Jul 13, 2019

Description

For mobile, replaces the native image component's use of the deprecated componentWillReceiveProps component lifecycle method in order to remove a warning. Additional detail, including testing directions, can be found in the related gutenberg-mobile PR.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
@etoledom
Copy link
Contributor

left a comment

Looks good! 🎉

Thank you @mchowning for taking care of this

@mchowning mchowning merged commit 4fa8431 into master Jul 15, 2019

1 of 6 checks passed

Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Filter merged Filter merged
Details
Travis CI - Pull Request Build Passed
Details

@mchowning mchowning deleted the rnmobile/remove_image_component_use_of_componentWillReceiveProps branch Jul 15, 2019

jffng added a commit to jffng/gutenberg that referenced this pull request Jul 18, 2019

jg314 added a commit to jg314/gutenberg that referenced this pull request Jul 19, 2019

@youknowriad youknowriad added this to the Gutenberg 6.2 milestone Jul 26, 2019

sbardian added a commit to sbardian/gutenberg that referenced this pull request Jul 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.