Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Block Movers disappear on middle breakpoints for full/wide blocks. #16579

Conversation

@jorgefilipecosta
Copy link
Member

commented Jul 14, 2019

Description

Fix: #16564

We had a rule to hide block mover until wide breakpoints, because otherwise it may be covered by the block toolbar. This rule caused a bug where the mover was not seen at all between mobile and wide breakpoints.
This PR removes this rule and to fix the problem where the toolbar covers the movers adds a rule to the toolbar that guarantees there is always space in the left for the movers.

How has this been tested?

I added an image block.
I set the block to full alignment.
I resized the screen from 500px until 1300 px and verified the movers were always shown and not covered by the toolbar.
I repeated the test for wide alignment.

Screenshots

Jul-14-2019 13-21-12

@kjellr

kjellr approved these changes Jul 15, 2019

Copy link
Contributor

left a comment

This looks great, thanks for the fix, @jorgefilipecosta! I've added one minor comment, but once that's taken care of, this is ready to land. 🚢

Update packages/block-editor/src/components/block-list/style.scss
Co-Authored-By: Kjell Reigstad <kjell.reigstad@automattic.com>

@jorgefilipecosta jorgefilipecosta merged commit 7a06a10 into master Jul 15, 2019

1 of 2 checks passed

Filter merged Filter merged
Details
Travis CI - Pull Request Build Passed
Details

@jorgefilipecosta jorgefilipecosta deleted the fix/block-movers-disappear-on-middle-breakpoints-for-full-wide-blocks branch Jul 15, 2019

@jorgefilipecosta

This comment has been minimized.

Copy link
Member Author

commented Jul 15, 2019

Thank you @kjellr for the review and for the suggestions 👍

@kjellr kjellr added this to the Gutenberg 6.2 milestone Jul 15, 2019

mcsf added a commit that referenced this pull request Jul 19, 2019

Fix: Block Movers disappear on middle breakpoints for full/wide block…
…s. (#16579)

* Fix: Block Movers disappear on middle breakpoints for full/wide blocks.

* Update packages/block-editor/src/components/block-list/style.scss

Co-Authored-By: Kjell Reigstad <kjell.reigstad@automattic.com>

jg314 added a commit to jg314/gutenberg that referenced this pull request Jul 19, 2019

Fix: Block Movers disappear on middle breakpoints for full/wide block…
…s. (WordPress#16579)

* Fix: Block Movers disappear on middle breakpoints for full/wide blocks.

* Update packages/block-editor/src/components/block-list/style.scss

Co-Authored-By: Kjell Reigstad <kjell.reigstad@automattic.com>

sbardian added a commit to sbardian/gutenberg that referenced this pull request Jul 29, 2019

Fix: Block Movers disappear on middle breakpoints for full/wide block…
…s. (WordPress#16579)

* Fix: Block Movers disappear on middle breakpoints for full/wide blocks.

* Update packages/block-editor/src/components/block-list/style.scss

Co-Authored-By: Kjell Reigstad <kjell.reigstad@automattic.com>
@paulwilde

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

Those toolbar CSS changes appear to have broken alignment of toolbars within inner blocks. See #16837.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.