Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Converting video shortcode results in empty block #16588

Merged

Conversation

@jorgefilipecosta
Copy link
Member

commented Jul 15, 2019

Description

Fixes: #15869

The shortcode to video transform was not handling the file type shortcode attributes as a possible source so the video shortcodes ended up being transformed into an empty video block.

This PR makes the transform handle all file type attributes documented in https://wordpress.org/support/article/video-shortcode/.

How has this been tested?

I added a class block.
I used the insert media button to insert an mp4 video.
I used the covert to blocks option.
I verified the video block works as expected (on master it is converted to an empty video block).

@jorgefilipecosta jorgefilipecosta force-pushed the fix/converting-video-shortcode-results-in-empty-block branch from 8701def to 33d90d1 Jul 15, 2019

@jorgefilipecosta jorgefilipecosta force-pushed the fix/converting-video-shortcode-results-in-empty-block branch from 33d90d1 to 4881993 Jul 16, 2019

@talldan
Copy link
Contributor

left a comment

Nice! Works well when I tested it.

@talldan talldan merged commit c323235 into master Jul 18, 2019

1 of 2 checks passed

Filter merged Filter merged
Details
Travis CI - Pull Request Build Passed
Details

@talldan talldan deleted the fix/converting-video-shortcode-results-in-empty-block branch Jul 18, 2019

jffng added a commit to jffng/gutenberg that referenced this pull request Jul 18, 2019

jg314 added a commit to jg314/gutenberg that referenced this pull request Jul 19, 2019

@youknowriad youknowriad added this to the Gutenberg 6.2 milestone Jul 26, 2019

sbardian added a commit to sbardian/gutenberg that referenced this pull request Jul 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.