Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Slimmer top/bottom spacing inside notices #16589
Currently, our Notice component ships with
This results in a lot of extra room on the top and bottom of the text:
This PR changes that spacing to
requested review from
Jul 15, 2019
aduth left a comment
Code-wise this looks good, and I agree the padding is both too much and inconsistent with the rest of the admin.
I was curious where the original values might have come from, and I note that the rest of the admin uses a total of 1em margin for paragraphs in a notice:
I don't know if we care to mimic this, or if it's necessary to adjust other style values here (there's default padding on the notice itself, in addition to the margin of the content).)
youknowriad left a comment •
I knew there was some back and forth here. It looks like this breaks the alignment of the "close" button in the regular notices of the editor.
@youknowriad good catch. I pushed a new change that sets the top/bottom margins to