Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support `hideLabelFromVision` prop for components using `BaseControl` #16701

Merged
merged 2 commits into from Jul 26, 2019

Conversation

@ocean90
Copy link
Member

commented Jul 22, 2019

Description

#16148 introduced the hideLabelFromVision prop to BaseControl. This PR adds the missing documentation and adds support for the prop to TextControl and TextareaControl.

@tellthemachines
Copy link
Contributor

left a comment

Looks great, apart from some minor issues with heading hierarchy in the md files. Left comments. Thanks for adding in all the docs!

@@ -127,6 +127,12 @@ If this property is added, a label will be generated using label property as the
- Type: `String`
- Required: No
### hideLabelFromVision

This comment has been minimized.

Copy link
@tellthemachines

tellthemachines Jul 24, 2019

Contributor

Minor: there's an extra level of nesting in this Readme so this heading should be an h4 instead of h3.

@@ -80,6 +80,13 @@ If this property is added, a label will be generated using label property as the
- Type: `String`
- Required: No

### hideLabelFromVision

This comment has been minimized.

Copy link
@tellthemachines

tellthemachines Jul 24, 2019

Contributor

This needs to be an h4 too, same as above.

@@ -104,6 +104,13 @@ If this property is added, a label will be generated using label property as the
- Type: `String`
- Required: No

### hideLabelFromVision

This comment has been minimized.

Copy link
@tellthemachines

tellthemachines Jul 24, 2019

Contributor

And again, h4.

@youknowriad youknowriad merged commit b8df976 into master Jul 26, 2019

1 of 2 checks passed

Filter merged Filter merged
Details
Travis CI - Pull Request Build Passed
Details

@youknowriad youknowriad deleted the fix/hideLabelFromVision branch Jul 26, 2019

@youknowriad youknowriad added this to the Gutenberg 6.2 milestone Jul 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.