Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Explore using a modal to replace the publish panel #16715
This is a rough attempt at adding a modal as described in #15847. This is a first step toward enhancing the publishing flow, based off of the designs by @sarahmonster and others tracked in #7602. It will need some additional work, but I thought it would be useful to get some feedback on it at this stage before continuing. The conversation about these changes is a bit fragmented so I am hoping that having some code to look at will help prioritize next steps.
@sarahmonster - Thank you for the great design work, you will notice some of the wording different from the mockups. In working through the code there were some variations between the existing panel and the mockups, usually around wording for scheduled posts. Where it made sense to me I kept the same messages if they were similar enough, but I'm happy to change as needed.
Open to any and all criticisms and suggestions. I used the existing postPublishPanel as a rough framework, and I need to review if some of the logic makes sense as a modal. I'll continue to update this as I have availability and depending on if it's looking like a direction worth exploring.
Additional plans for now:
I have made some updates to bring this into line with an updated prototype in #7602 (comment). I also made a few intentional changes:
Leaving this as a Draft PR as there is quite a bit of back and forth in #7602 about whether a modal is a step forward or not. Hoping that this work will move the conversation forward by being able to experience it, but understand this is far from a settled direction for the publishing flow. (I will also work on getting a version up with this prototype in a full screen modal early next week @karmatosed)