Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Close "Block Styles" section on transformBlockTo e2e test helper. #16739

Merged
merged 1 commit into from Jul 30, 2019

Conversation

@jorgefilipecosta
Copy link
Member

commented Jul 24, 2019

Description

In pr #16113, the end to end tests are failing, because, during a transform test a button is not visible in the test screen height (that PR increases the height of block style buttons). This PR fixes the problem by first closing the "Block Styles" button. This change replicates the same a human user would have to do to press the transform button in that screen resolution.

How has this been tested?

Merge #16113 temporarily in this branch and verify end to end transform tests pass:
npm run test-e2e packages/e2e-tests/specs/block-transforms.test.js

@jorgefilipecosta jorgefilipecosta force-pushed the fix/close-block-styles-panel-on-transform-block-to branch from d5158ac to f34daaa Jul 24, 2019

@jorgefilipecosta jorgefilipecosta requested a review from getdave Jul 25, 2019

@getdave
Copy link
Contributor

left a comment

Hi @jorgefilipecosta. Thank you so much for working on this and sorry it's taken so long for me to get around to testing.

I'm back on BlockPreview this week and I've just tested this branch by following your instructions and everything now works perfectly. Therefore I think we're good to merge.

@getdave getdave merged commit 4ac7dc9 into master Jul 30, 2019

1 of 3 checks passed

Milestone It Milestone It
Details
Milestone It Milestone It
Details
Travis CI - Pull Request Build Passed
Details

@github-actions github-actions bot added this to the Gutenberg 6.3 milestone Jul 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.