Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): remove nonexistent `getBlockDependantsCacheBust` selector reference #16756

Merged
merged 2 commits into from Jul 26, 2019

Conversation

@dsifford
Copy link
Contributor

commented Jul 25, 2019

Description

This PR removes a selector reference from core/editor that references a deleted selector in core/block-editor

How has this been tested?

Unit tests still pass.

Screenshots

N/A

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@dsifford dsifford requested review from talldan and youknowriad as code owners Jul 25, 2019

@youknowriad

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

You should run npm run docs:build to regenerate the docs too.

@dsifford

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2019

Got it. I'm on it...

@youknowriad
Copy link
Contributor

left a comment

LGTM 👍

@youknowriad youknowriad merged commit e54043a into master Jul 26, 2019

1 of 6 checks passed

Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Travis CI - Pull Request Build Passed
Details

@youknowriad youknowriad deleted the fix/remove-nonexistent-selector-reference branch Jul 26, 2019

@youknowriad youknowriad added this to the Gutenberg 6.2 milestone Jul 26, 2019

sbardian added a commit to sbardian/gutenberg that referenced this pull request Jul 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.