Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Widgets screen block toolbar overlaps the Block Area accordion #16765

Conversation

@jorgefilipecosta
Copy link
Member

commented Jul 26, 2019

Fix: #16602

This PR adds small padding to the block list container for widget areas to make sure the block toolbars don't overlap the block area accordion.

How has this been tested?

I went to the block widgets screen.
I added a block like an image block and verified the block toolbar does not overlap the block area accordion.

@draganescu
Copy link
Contributor

left a comment

There still seems to be some overlap for me in Safari:

Screenshot 2019-08-05 at 15 20 01

@jorgefilipecosta jorgefilipecosta force-pushed the fix/widgets-screen-block-toolbar-overlaps-the-block-area-accordion-trigger branch from 4a5e61f to 93390bf Aug 5, 2019

@jorgefilipecosta

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2019

Hi @draganescu, thank you for the review the dimensions were updated it should work as expected now.

@mapk

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

I just tested and no longer see an overlap in FF or in Chrome. Thanks! This looks good to 🚢 .

Screen Shot 2019-08-05 at 2 59 59 PM

@jorgefilipecosta jorgefilipecosta merged commit 71db908 into master Aug 5, 2019

1 of 2 checks passed

Milestone It Milestone It
Details
Travis CI - Pull Request Build Passed
Details

@jorgefilipecosta jorgefilipecosta deleted the fix/widgets-screen-block-toolbar-overlaps-the-block-area-accordion-trigger branch Aug 5, 2019

@youknowriad youknowriad added this to the Gutenberg 6.3 milestone Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.