Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Restore default opacity to buttons #16769

Merged
merged 2 commits into from Jul 26, 2019

Conversation

@aduth
Copy link
Member

commented Jul 26, 2019

(Partly) extracted: #16761
Related (reverts): #16581
Related (partially reverts): #16103

This pull request seeks to restore default dimmed opacity to buttons, removed as part of #16103. This can be seen for DropdownMenu buttons in #16581, and for the Undo/Redo buttons of a new post.

Before After
Before After

It tries to respect the intention of #16103 by effectively unsetting the default opacity for isPrimary and isDefault (the "WordPress-styled") button variants, thus not regressing the intention of that pull request.

It's assumed that, since .components-button styling otherwise resets all browser-default appearance of a button, there should be some effect to indicate the disabled state of a button, as otherwise (as seen in the "Before" screenshot) they cannot be distinguished from non-disabled buttons.

Testing Instructions:

Repeat testing instructions from #16103

Verify buttons for Undo/Redo for a new post appear as disabled

@aduth aduth requested review from mapk, talldan and kjellr Jul 26, 2019

@aduth aduth changed the title Restore/button disabled style Components: Restore default opacity to buttons Jul 26, 2019

@jorgefilipecosta
Copy link
Member

left a comment

Worked as expected in my tests 👍

@aduth aduth merged commit 50880f6 into master Jul 26, 2019

1 of 15 checks passed

Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Travis CI - Pull Request Build Passed
Details

@aduth aduth deleted the restore/button-disabled-style branch Jul 26, 2019

@youknowriad youknowriad added this to the Gutenberg 6.2 milestone Jul 29, 2019

sbardian added a commit to sbardian/gutenberg that referenced this pull request Jul 29, 2019

Components: Restore default opacity to buttons (WordPress#16769)
* Components: Restore default opacity to buttons

* Components: Remove redundant DropdownMenu disabled styling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.