Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove edit gallery toolbar button #16778

Merged
merged 1 commit into from Aug 9, 2019

Conversation

@jorgefilipecosta
Copy link
Member

commented Jul 26, 2019

Description

This PR follows the suggestion discussed on #16548 (comment) and removes the edit gallery button from the gallery block.

How has this been tested?

I created a gallery I added some images and I verified the edit gallery button does not appear on the block toolbar.

@youknowriad
Copy link
Contributor

left a comment

I personally feel it's better because the way that button worked was confusing and now we can move, remove and add images without opening the media library (inline).

We might need a button in the image itself to edit one image (The last mockup here should be a good starting point #11952)

That said, let's have more thoughts here @karmatosed @mapk @mtias @kjellr

@kjellr

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2019

Interesting. As others noted in the previous thread, the main thing missing here is the ability to edit metadata for individual images. Maybe we should add in a control like this?

Frame 2

Anyway, as long as we have a plan for that, I think it's probably okay to remove this menu item.

(As an aside, I originally missed those move controls, so I opened a PR to help make them a little larger. Really though, I can't wait for drag & drop to happen for these — I imagine that'll be the primary way of rearranging galleries for many people.)

@mapk

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

I'm trying to test this out, but it appears I no longer have a Gallery block. Am I gutenberging wrong?

gallery

@mapk

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

Nevermind, I had the Gallery block hidden in the Block Manager. It's working as expected! Basically, I was definitely Gutenberging wrong.

@jorgefilipecosta

This comment has been minimized.

Copy link
Member Author

commented Aug 8, 2019

It's working as expected!

Hi @mapk, is that a green light :)?

@jorgefilipecosta jorgefilipecosta force-pushed the remove/edit-gallery-toolbar-button branch from 4e19d05 to bdece04 Aug 8, 2019

@mapk
mapk approved these changes Aug 8, 2019
Copy link
Contributor

left a comment

Yep, good to go! Thanks!

@jorgefilipecosta jorgefilipecosta merged commit 6402f95 into master Aug 9, 2019

1 of 4 checks passed

Filter opened Filter opened
Details
Filter opened Filter opened
Details
Milestone It Milestone It
Details
Travis CI - Pull Request Build Passed
Details

@jorgefilipecosta jorgefilipecosta deleted the remove/edit-gallery-toolbar-button branch Aug 9, 2019

@youknowriad youknowriad added this to the Gutenberg 6.3 milestone Aug 9, 2019

gziolo added a commit that referenced this pull request Aug 29, 2019
gziolo added a commit that referenced this pull request Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.