Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove edit gallery toolbar button #16778
This PR follows the suggestion discussed on #16548 (comment) and removes the edit gallery button from the gallery block.
How has this been tested?
I created a gallery I added some images and I verified the edit gallery button does not appear on the block toolbar.
youknowriad left a comment
I personally feel it's better because the way that button worked was confusing and now we can move, remove and add images without opening the media library (inline).
We might need a button in the image itself to edit one image (The last mockup here should be a good starting point #11952)
Interesting. As others noted in the previous thread, the main thing missing here is the ability to edit metadata for individual images. Maybe we should add in a control like this?
Anyway, as long as we have a plan for that, I think it's probably okay to remove this menu item.
(As an aside, I originally missed those move controls, so I opened a PR to help make them a little larger. Really though, I can't wait for drag & drop to happen for these — I imagine that'll be the primary way of rearranging galleries for many people.)