Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Try adding a subtle animation to innerblock selection when padding is added. #16817
When it's necessary to prevent overlap, #14961 adds some additional padding to
In that issue, we discussed adopting a very subtle
After: (The GIF is slowed down to make the animation more visible)
This seems pretty subtle, and helps make this smoother by just a little bit. The only issue I'm seeing is that it is unnecessarily applied to placeholders as well:
I don't think there's a way to turn this off, without the addition of a
requested review from
Jul 30, 2019
What this does is target appenders and placeholders inside of selected blocks that have the extra padding, and applies a second animation to them. The original animation scales things from
@jasmussen, I'd love your thoughts on this approach.
I definitely think that animation helps smooth out this experience, which can be slightly jarring otherwise. Given the recent feedback on the clickthrough, I think this is one of the ones to sit on for a little bit as we look to explore putting everything in its right place. But the technique — the black magic that makes this work — definitely keep that one in the old noodle, as I suspect we'll want to use that in many, many contexts.