Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color Palette: add a purple / violet color option to the default color palette. #16833

Merged
merged 1 commit into from Aug 1, 2019

Conversation

@mtias
Copy link
Contributor

commented Jul 31, 2019

This should make the color spectrum a bit more complete.

image

@mtias mtias force-pushed the update/default-color-palette branch from 069e428 to 0039be0 Jul 31, 2019

@kjellr
kjellr approved these changes Jul 31, 2019
Copy link
Contributor

left a comment

🌈 Looks good!

@karmatosed

This comment has been minimized.

Copy link
Member

commented Jul 31, 2019

Yay! This is great.

@kjellr

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

This is an aside, but I was wondering if we should have white as one of our color options? This purple and our red color throw up a contrast warning when you first use them as backgrounds. This is easily fixed by using a white text color, but it's a little rough to have to go into the custom color picker to do that:

purple-white

I also find myself frequently wanting to set white text when in the Cover block for instance.

@mtias

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

Agreed a white would be useful, also would be good to try a few more grays by default.

@karmatosed

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

Agreed a white would be useful, also would be good to try a few more grays by default.

This is just an idea but what about on hovering over a color and there being a range of options in that color? The idea may be totally not a great one but my thinking is it stops having lots of colors showing by default, particularly if we're talking shades.

@mtias mtias merged commit 9169895 into master Aug 1, 2019

1 of 4 checks passed

Filter opened Filter opened
Details
Filter opened Filter opened
Details
Milestone It Milestone It
Details
Travis CI - Pull Request Build Passed
Details

@mtias mtias deleted the update/default-color-palette branch Aug 1, 2019

@youknowriad youknowriad added this to the Gutenberg 6.3 milestone Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.