Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra specificity to toolbar position for wide/full blocks #16858

Merged
merged 1 commit into from Aug 2, 2019

Conversation

@kjellr
Copy link
Contributor

commented Aug 1, 2019

Fixes #16837.

At certain breakpoints, the position of the toolbar for wide/full blocks is offset to account for block mover controls. As added in #16579, these styles unnecessarily flow down into innerblock toolbars. This PR adds some extra specificity so that the rules only go into effect for the toolbar of the wide/full block itself.

Before

Screen Shot 2019-08-01 at 9 43 48 AM

Screen Shot 2019-08-01 at 9 48 29 AM

After

Screen Shot 2019-08-01 at 9 38 32 AM

Screen Shot 2019-08-01 at 9 48 54 AM

Add extra specificity to toolbar position
So that it doesn't apply to innerblock toolbars as well.
@youknowriad
Copy link
Contributor

left a comment

Seems to work as intended.

@kjellr kjellr merged commit 2573a5a into master Aug 2, 2019

3 of 30 checks passed

Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
First Time Contributor First Time Contributor
Details
Assign Fixed Issues Assign Fixed Issues
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Milestone It Milestone It
Details
Filter opened Filter opened
Details
Filter opened Filter opened
Details
Travis CI - Pull Request Build Passed
Details

@kjellr kjellr deleted the fix/toolbar-spacing-for-innerblocks branch Aug 2, 2019

@youknowriad youknowriad added this to the Gutenberg 6.3 milestone Aug 9, 2019

gziolo added a commit that referenced this pull request Aug 29, 2019
Add extra specificity to toolbar position (#16858)
So that it doesn't apply to innerblock toolbars as well.
gziolo added a commit that referenced this pull request Aug 29, 2019
Add extra specificity to toolbar position (#16858)
So that it doesn't apply to innerblock toolbars as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.