Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Core Data: Add support for entity edits and undo history. #16867
Based on #16761
This PR follows a similar approach to adding edit and history support as #16761, but simplifies a lot of the logic by not relying on hacking property descriptors to let properties opt out of history tracking and change detection. Instead, it lets entity configs define which properties should opt out.
It also has a different take on the store structure which makes it play nicer with the current code and thus minimizes required changes.
The approach to undo/redo has also changed slightly, because it wasn't handling certain scenarios like undo => edit => redo.
How has this been tested?
The editor store refactor from #16761 was cherry picked on top and everything worked as expected.
Types of Changes
New Feature: Add edit, undo/redo history, and change detection support to core data entities.
Aug 2, 2019
youknowriad left a comment
Do you think we should separate the core-data changes from the editor changes. I feel we can land the
Yeah, definitely, I just wanted to test things together, I probably shouldn't have pushed, but I am about to reduce the scope here again and implement your suggestions.